Welcome, Guest
Python Scripts for ComicRack

TOPIC: Data Manager 2.xx Series for ComicRack

Data Manager 2.xx Series for ComicRack 5 months 1 week ago #47505

  • Surfal666
  • Surfal666's Avatar
  • Offline
  • Senior Boarder
  • Posts: 64
  • Thank you received: 4
  • Karma: 2
Surfal666 wrote:
jkthemac wrote:
Noticed a more serious bug.

I am no longer able to make rules based upon custom fields. The existing ones work, but if I try to make a new one there is nothing in the drop down. I can't edit them either.

Seconded. This is biting me hard right now.

I've worked around this by editing dataman.dat directly. It's just XML...

Can I make a UI/UX suggestion? After DM runs, the runProcess window 1) does not resize well, making it hard to read 2) shows a final line like "5 Books were modified. 0 Values were changed.", which is confusing... I know that it means 5 (unique) books matched against the rules and none of the actions resulted in changes, but it just reads strangely.

Can we get an option to log to a file as well?

(DM is a brilliant tool. Managing a large collection without it would be a hellish experience.)
The administrator has disabled public write access.

Data Manager 2.xx Series for ComicRack 5 months 1 week ago #47512

  • T3KN0Gh057
  • T3KN0Gh057's Avatar
  • Offline
  • Platinum Boarder
  • Posts: 407
  • Thank you received: 114
  • Karma: 27
There's a update on the first page fixing custom field editing.

Surfal666 wrote:
Can I make a UI/UX suggestion? After DM runs, the runProcess window 1) does not resize well, making it hard to read
This is something I'm aware of and have been meaning to get around to fixing.
2) shows a final line like "5 Books were modified. 0 Values were changed.", which is confusing... I know that it means 5 (unique) books matched against the rules and none of the actions resulted in changes, but it just reads strangely.

What's so confusing about that? It's straight forward how many books were candidates for modification and how many values were changed over all of those books that were candidates. It seemed pretty straight forward to me, Due to how the books are proccessed this is just about as clear as the output can report for now.
Can we get an option to log to a file as well?

if you mean a copy of the report of changes, the log file already is created in the script folder as dataman.log
Last Edit: 5 months 1 week ago by T3KN0Gh057.
The administrator has disabled public write access.
The following user(s) said Thank You: Surfal666, jkthemac

Data Manager 2.xx Series for ComicRack 5 months 1 week ago #47513

  • Surfal666
  • Surfal666's Avatar
  • Offline
  • Senior Boarder
  • Posts: 64
  • Thank you received: 4
  • Karma: 2
T3KN0Gh057 wrote:
2) shows a final line like "5 Books were modified. 0 Values were changed.", which is confusing... I know that it means 5 (unique) books matched against the rules and none of the actions resulted in changes, but it just reads strangely.

What's so confusing about that?

Well, the confusing part is that it says 5 books were modified, but in reality, no books were modified.
surfal666@rex:/c/users/surfal666/appdata/roaming/cyo/ComicRack/Scripts/Data Manager $ diff -u runProcess.original.py runProcess.py
--- runProcess.original.py      2017-04-23 17:40:54.641826700 -0400
+++ runProcess.py       2017-05-13 04:31:05.964021700 -0400
@@ -155,7 +155,25 @@


         #add touch count to log
-        strReport = strReport + System.Environment.NewLine + System.Environment.NewLine + bookTouchCount.ToString() + ' Books were modified. ' + fieldTouchCount.ToString() + ' Values were changed'
+        strReport = strReport + System.Environment.NewLine + System.Environment.NewLine
+        if bookTouchCount > 0:
+            strReport = strReport + bookTouchCount.ToString() + ' book'
+            if bookTouchCount == 1:
+                strReport = strReport + ' was '
+            else:
+                strReport = strReport + 's were '
+            if fieldTouchCount > 0:
+                strReport = strReport + 'modified. ' + fieldTouchCount.ToString() + ' value'
+                if fieldTouchCount == 1:
+                    strReport = strReport + ' was'
+                else:
+                    strReport = strReport + 's were'
+                strReport = strReport + ' changed.'
+            else:
+                strReport = strReport + 'matched. No values were changed.'
+        else:
+            strReport = strReport + 'No books matched.'
+
         self._bgwProcess.ReportProgress(100, [count, strReport])

         #write out report

And somehow I'd never noticed that logfile. sigh. thanks.
The administrator has disabled public write access.

Data Manager 2.xx Series for ComicRack 5 months 1 week ago #47518

  • jkthemac
  • jkthemac's Avatar
  • Offline
  • Platinum Boarder
  • Posts: 760
  • Thank you received: 248
  • Karma: 55
Thanks for the update and continued support of this plug-in.

Just a gentle reminder you didn't put the new version of ReplaceReferenceStrings in this update. I have manually replaced it fine, but am holding off working on my data saving rules until it will work for those that have the latest version.
Last Edit: 5 months 1 week ago by jkthemac.
The administrator has disabled public write access.

Data Manager 2.xx Series for ComicRack 5 months 1 week ago #47522

  • T3KN0Gh057
  • T3KN0Gh057's Avatar
  • Offline
  • Platinum Boarder
  • Posts: 407
  • Thank you received: 114
  • Karma: 27
jkthemac wrote:
Thanks for the update and continued support of this plug-in.

Just a gentle reminder you didn't put the new version of ReplaceReferenceStrings in this update. I have manually replaced it fine, but am holding off working on my data saving rules until it will work for those that have the latest version.

Haven't forgotten this, still working on making sure i haven't caused any extra bugs with other changes recently made (been trying to add user variables so you can save values to move across books) that won't be official til 2.08 but some code is already a part of my next commits.

The current release was just a matter of updating the editor and ini files.
Last Edit: 5 months 1 week ago by T3KN0Gh057.
The administrator has disabled public write access.

Data Manager 2.xx Series for ComicRack 5 months 6 days ago #47530

  • jkthemac
  • jkthemac's Avatar
  • Offline
  • Platinum Boarder
  • Posts: 760
  • Thank you received: 248
  • Karma: 55
That sounds very promising. Variables would certainly be useful. It would make tricky things relatively easy to accomplish.

For the record, I haven't seen any negatives after updating to your suggested code for ReplaceReferenceStrings and I have quite a varied set of rules that usually fall over with any such issues.
Last Edit: 5 months 6 days ago by jkthemac.
The administrator has disabled public write access.

Data Manager 2.xx Series for ComicRack 5 months 4 days ago #47536

  • T3KN0Gh057
  • T3KN0Gh057's Avatar
  • Offline
  • Platinum Boarder
  • Posts: 407
  • Thank you received: 114
  • Karma: 27
Just to keep you up on what I'm currently doing with the script and what will be fixed/changed in next release:

Changelog for upcoming 2.05.12r797
  • Adding fixed ReplaceReferenceString function
  • checked that preperation for future changes don't interfere with scripts current operation
  • seperating List Modifiers from text modifiers, so that comma seperated lists can be handled as lists or text and there is no confusion of intent, new modifiers for list only options are as follows : ListContains, ListContainsAnyOf, ListContainsAllOf, ListItemsContain, ListItemsContainAnyOf, ListItemsContainsAllOf (addin 'Not' before each of these to invert matches), using list with any other modifiers will assume use as a text string.
  • added case sensitivity for rules & actions

  • I expect to have this out by tomorrow.
Last Edit: 5 months 4 days ago by T3KN0Gh057.
The administrator has disabled public write access.
The following user(s) said Thank You: jkthemac

Data Manager 2.xx Series for ComicRack 5 months 4 days ago #47537

  • Surfal666
  • Surfal666's Avatar
  • Offline
  • Senior Boarder
  • Posts: 64
  • Thank you received: 4
  • Karma: 2
T3KN0Gh057 wrote:

Changelog for upcoming 2.05.12r797

  • added case sensitivity for rules & actions


Will there be a toggle to maintain case-insensitivity?
The administrator has disabled public write access.

Data Manager 2.xx Series for ComicRack 5 months 3 days ago #47560

  • jkthemac
  • jkthemac's Avatar
  • Offline
  • Platinum Boarder
  • Posts: 760
  • Thank you received: 248
  • Karma: 55
T3KN0Gh057 wrote:
Just to keep you up on what I'm currently doing with the script and what will be fixed/changed in next release:

Changelog for upcoming 2.05.12r797
  • Adding fixed ReplaceReferenceString function
  • checked that preperation for future changes don't interfere with scripts current operation
  • seperating List Modifiers from text modifiers, so that comma seperated lists can be handled as lists or text and there is no confusion of intent, new modifiers for list only options are as follows : ListContains, ListContainsAnyOf, ListContainsAllOf, ListItemsContain, ListItemsContainAnyOf, ListItemsContainsAllOf (addin 'Not' before each of these to invert matches), using list with any other modifiers will assume use as a text string.
  • added case sensitivity for rules & actions

  • I expect to have this out by tomorrow.

I approve of your thinking on Lists. The ability to check for a flag left in tags opens up a lot of possibilities.

Have you considered an 'Add to List' so we can add things without messing around with commas and empty lists?
Last Edit: 5 months 3 days ago by jkthemac.
The administrator has disabled public write access.

Data Manager 2.xx Series for ComicRack 5 months 2 days ago #47562

  • T3KN0Gh057
  • T3KN0Gh057's Avatar
  • Offline
  • Platinum Boarder
  • Posts: 407
  • Thank you received: 114
  • Karma: 27
Surfal666 wrote:
Will there be a toggle to maintain case-insensitivity?

Yes sir there will be the ability to toggle case sensitivity.
jkthemac wrote:
I approve of your thinking on Lists. The ability to check for a flag left in tags opens up a lot of possibilities.

Have you considered an 'Add to List' so we can add things without messing around with commas and empty lists?

Good idea. I'll take it to the logical next step though and add "AddListItem"/"RemoveListItem"/"ReplaceListItem" to round out the capabilities.

I know I'm running later than i said, but I had an unexpected visitor from out of town since i made that post that i haven't seen in a while.
All the code changes are already made the stall is making the GUI handle new changes. it should be very soon however.
Last Edit: 5 months 2 days ago by T3KN0Gh057.
The administrator has disabled public write access.
The following user(s) said Thank You: Surfal666, jkthemac
Time to create page: 0.371 seconds

Who's Online

We have 207 guests and 5 members online