Welcome, Guest
Python Scripts for ComicRack

TOPIC: Comic Vine Scraper Patch [Not Official]

Comic Vine Scraper Patch [Not Official] 8 months 1 week ago #49069

  • Xelloss
  • Xelloss's Avatar
  • Offline
  • Platinum Boarder
  • Posts: 596
  • Thank you received: 150
  • Karma: 30
krandor wrote:
You were asking for things that didn't match. Here is one that is an interesting case.

Filename - "Batman v2 50 (2016) (Webrip) (The Last Kryptonian-DCP.cbz" (correct no closing parenthis)

So CVS Searched for

Batman (The Last Krytonian-DCP

Which of course failed. Just removed the extra stuff and it worked.

Definitely a case where they named the file wrong.

I see why it failed... Let me see if I can think of something...
Last Edit: 8 months 1 week ago by Xelloss.
The administrator has disabled public write access.

Comic Vine Scraper Patch [Not Official] 8 months 1 week ago #49070

  • Xelloss
  • Xelloss's Avatar
  • Offline
  • Platinum Boarder
  • Posts: 596
  • Thank you received: 150
  • Karma: 30
Ok, i have seen this case... And I am sorry I cannot do anything in the piece of code I am working on.

What I have is the already filtered search string, so I cannot discriminate between "Batman (The Last Krytonian-DCP" and "batman the last kryptonian dcp", which my code begin reducing till it finds something with Batman The Last...

In any case something could be done before filtering the text, and use the ( as a marker somehow...

Personally I would delete any words after the number for searches, but again, that is not parsed in the piece of code I am editing
Last Edit: 8 months 1 week ago by Xelloss.
The administrator has disabled public write access.

Comic Vine Scraper Patch [Not Official] 8 months 1 week ago #49071

  • beardyandy
  • beardyandy's Avatar
  • Offline
  • Senior Boarder
  • Posts: 48
  • Thank you received: 5
  • Karma: 0
That error was in 2-3

I hadn't seen 2-3-5 but have tested it now and it still errors.

Filename was BD FR - Wunderwaffen présente Zeppelin's war - Les Raiders de la nuit v1
The administrator has disabled public write access.
The following user(s) said Thank You: Xelloss

Comic Vine Scraper Patch [Not Official] 8 months 1 week ago #49072

  • beardyandy
  • beardyandy's Avatar
  • Offline
  • Senior Boarder
  • Posts: 48
  • Thank you received: 5
  • Karma: 0
and just tested with another file with é in it - same error. So it's unicode, rather than that 1 file I assume
The administrator has disabled public write access.
The following user(s) said Thank You: Xelloss

Comic Vine Scraper Patch [Not Official] 8 months 1 week ago #49073

  • krandor
  • krandor's Avatar
  • Offline
  • Gold Boarder
  • Posts: 313
  • Thank you received: 34
  • Karma: 5
Xelloss wrote:
Ok, i have seen this case... And I am sorry I cannot do anything in the piece of code I am working on.

Fiugured as much but was just passing it along as you asked. Definitely a non-normal type situation.
The administrator has disabled public write access.

Comic Vine Scraper Patch [Not Official] 8 months 1 week ago #49074

  • krandor
  • krandor's Avatar
  • Offline
  • Gold Boarder
  • Posts: 313
  • Thank you received: 34
  • Karma: 5
and I ran through a fun hundred tonight and the new scipt worked good. Outside of the one case I gave you the only other real issues were with the "Batman and Robin" sequence where they renamed the comic every issue and there is really no way for the scraper to handle that.

SO far looks real good.
The administrator has disabled public write access.
The following user(s) said Thank You: Xelloss

Comic Vine Scraper Patch [Not Official] 8 months 1 week ago #49075

  • Xelloss
  • Xelloss's Avatar
  • Offline
  • Platinum Boarder
  • Posts: 596
  • Thank you received: 150
  • Karma: 30
beardyandy wrote:
and just tested with another file with é in it - same error. So it's unicode, rather than that 1 file I assume

I need the error log with the last version to.know the line where this error is happenning to fix it... This bug is really worring me
The administrator has disabled public write access.

Comic Vine Scraper Patch [Not Official] 8 months 1 week ago #49077

  • beardyandy
  • beardyandy's Avatar
  • Offline
  • Senior Boarder
  • Posts: 48
  • Thank you received: 5
  • Karma: 0

PYTHON ERROR
Caught UnicodeDecodeError: ('unknown', u'\xfc', 0, 1, '')
Traceback (most recent call last):
File "\\name\portableapps\comicrack\Data\Scripts\Comic Vine Scraper\scrapeengine.py", line 143, in scrape
File "\\name\portableapps\comicrack\Data\Scripts\Comic Vine Scraper\scrapeengine.py", line 257, in _ScrapeEngine__scrape
File "\\name\portableapps\comicrack\Data\Scripts\Comic Vine Scraper\scrapeengine.py", line 426, in _ScrapeEngine__scrape_book
File "\\name\portableapps\comicrack\Data\Scripts\Comic Vine Scraper\automatcher.py", line 38, in find_series_ref
File "\\name\portableapps\comicrack\Data\Scripts\Comic Vine Scraper\automatcher.py", line 75, in __find_best_series
File "\\name\portableapps\comicrack\Data\Scripts\Comic Vine Scraper\db.py", line 156, in query_series_refs
File "\\name\portableapps\comicrack\Data\Scripts\Comic Vine Scraper\cvdb.py", line 143, in _query_series_refs
File "\\name\portableapps\comicrack\Data\Scripts\Comic Vine Scraper\cvdb.py", line 217, in __query_series_refs
The administrator has disabled public write access.

Comic Vine Scraper Patch [Not Official] 8 months 1 week ago #49078

  • beardyandy
  • beardyandy's Avatar
  • Offline
  • Senior Boarder
  • Posts: 48
  • Thank you received: 5
  • Karma: 0
Just FYI, replacing/ removing the character from the series name allows it to complete without problems - even when it's not changed in filename. So I'd guess you could replace these (?)

BUT I'm an English speaker and don't have a lot of comics in foreign languages - and appreciate it's not particularly elegant a solution
The administrator has disabled public write access.

Comic Vine Scraper Patch [Not Official] 8 months 1 week ago #49079

  • Xelloss
  • Xelloss's Avatar
  • Offline
  • Platinum Boarder
  • Posts: 596
  • Thank you received: 150
  • Karma: 30
I will look at it today :)
The administrator has disabled public write access.
Time to create page: 0.724 seconds

Who's Online

We have 135 guests and 2 members online